Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gemfile: add WDM gem. #27449

Closed
wants to merge 1 commit into from
Closed

Gemfile: add WDM gem. #27449

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Member

It's recommended on Windows so that watch isn't (so) slow.

@XhmikosR XhmikosR requested a review from Johann-S October 15, 2018 13:49
@XhmikosR
Gemfile: add WDM gem.
7ac52b6 
It's recommended on Windows so that watch isn't (so) slow.

Also make a few cosmetic changes.
@XhmikosR
Copy link
Member Author

XhmikosR commented Oct 15, 2018 •
edited
Loading

OK this doesn't work with --deployment...

So the options are:

  1. we remove the deployment flag in Travis
  2. we always install WDM regardless of the platform; not sure about this since I haven't tried other OS'es
  3. we drop this patch completely

@XhmikosR XhmikosR closed this Oct 16, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-wdm branch October 16, 2018 20:48
@XhmikosR XhmikosR mentioned this pull request Nov 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
build v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @Johann-S