Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jekyll: switch to localhost #27552

Merged
merged 5 commits into from
Nov 4, 2018
Merged

Jekyll: switch to localhost #27552

merged 5 commits into from
Nov 4, 2018

Conversation

XhmikosR
Copy link
Member

0.0.0.0 has issues on Windows.

`0.0.0.0` has issues on Windows.
@patrickhlauke
Copy link
Member

patrickhlauke commented Oct 30, 2018

with that change, i can't run npm run docs-serve on the machine and access the docs from another machine on my local network (using the IP of the machine, e.g. http://192.168.1.163:9001 - the request from the other machine/phone/device times out). with the current 0.0.0.0 i can still use http://localhost:9001 on my local machine, AND i can access the docs from any other machine in my network using the http://192.168.1.163:9001 (depending on IP of machine) address...

@XhmikosR
Copy link
Member Author

Well, yeah but doesn't work for me then.

@patrickhlauke
Copy link
Member

adding some context from the slack chat: what isn't currently working with using 0.0.0.0 is that redirects end up using that address, and then don't work (because the magic 0.0.0.0 isn't actually valid, and gets changed behind the scenes...but not, it seems, by the redirect plugin)

Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, i'd like to keep the ability to access the docs running on one machine from another machine (like a phone/tablet) on the same network. using localhost breaks this. xref https://zarino.co.uk/post/jekyll-local-network/

a different approach - perhaps using some sort of "if running locally for dev purposes, use this config" which could set the baseurl or url to localhost explicitly, making redirects work then - would be better perhaps

@XhmikosR
Copy link
Member Author

Like I said on Slack, you can use a custom --host flag. The default should work for most people.

@mdo mdo mentioned this pull request Nov 4, 2018
@XhmikosR XhmikosR merged commit d275096 into v4-dev Nov 4, 2018
@XhmikosR XhmikosR deleted the v4-dev-xmr-jekyll-host branch November 4, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants