Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix margin above toast when previous toast is hidden #27820

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

MartijnCuppens
Copy link
Member

@MartijnCuppens MartijnCuppens commented Dec 12, 2018

@MartijnCuppens MartijnCuppens requested a review from a team as a code owner December 12, 2018 13:14
@MartijnCuppens MartijnCuppens changed the title Fix margin hidden multiple toasts Fix margin above toast when previous toast is hidden Dec 12, 2018
@MartijnCuppens
Copy link
Member Author

Not sure if this fixes #27807, we still have an inconsistent behaviour between the alerts and toasts (alerts are removed from the DOM, toasts aren't)

@Johann-S
Copy link
Member

Johann-S commented Dec 12, 2018

I think it's not the same behavior we want for Alerts and Toasts. Alerts have a state (warning, error, info) and should be displayed once, on the other hand Toasts don't have states and can be reusable

Copy link
Member

@Johann-S Johann-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MartijnCuppens MartijnCuppens merged commit dbadf24 into v4-dev Dec 12, 2018
@MartijnCuppens MartijnCuppens deleted the v4-dev-martijncuppens-toast-margin-fix branch December 12, 2018 13:23
@mdo mdo mentioned this pull request Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants