Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v5: Add cursor util #30563

Closed
wants to merge 1 commit into from
Closed

v5: Add cursor util #30563

wants to merge 1 commit into from

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 11, 2020 •
edited
Loading

v5 version of #30562. Fixes #23709.

@mdo mdo requested a review from a team as a code owner April 11, 2020 20:44
@mdo mdo mentioned this pull request Apr 11, 2020
Closed
@MartijnCuppens
Copy link
Member

Gonna stick with my opinion in #23709 (comment). A lot of people want this, but no one seems to be able to define a use case for the cursor-pointer utility.

I'm afraid developers will just abuse this utility and add this class to elements which aren't focusable with keyboard navigation.

@mdo
Copy link
Member Author

mdo commented Apr 13, 2020

A lot of people want this, but no one seems to be able to define a use case for the cursor-pointer utility.

Good point, just commented again on that issue.

@ffoodd
Copy link
Member

ffoodd commented Apr 13, 2020

I agree with @MartijnCuppens here. Cursors are usually good natively, and a very precious indicator of browser and OS interaction layer.

With these utilities, it'd be too easy to mess things up. If something is wrong with our cursors, those styles should belong to reboot.

Pointer events and user-select can be really helpful since they affect behaviour, but cursors can be really misleading.

@MartijnCuppens MartijnCuppens mentioned this pull request Apr 30, 2020
Merged
@mdo
Copy link
Member Author

mdo commented May 18, 2020

Coming back to this after shipping the interactions and role="button" in v4.5, thinking this needs to be updated to include that instead, right?

@mdo mdo mentioned this pull request Jun 16, 2020
Merged
@mdo
Copy link
Member Author

mdo commented Jun 16, 2020

Replaced by #31040.

@mdo mdo closed this Jun 16, 2020
@mdo mdo deleted the v5-cursor-pointer branch June 16, 2020 02:01
mdo added a commit that referenced this pull request Jun 16, 2020
@mdo
v5: Add role=button cursor in Reboot
f8c195b 
Ports the changes from #30562 made in v4.5 and adds them to v5. This replaces #30563 which sought to add this to the utility API, but the v4 PR shifted to implement an accessible solution vs a lone utility.
mdo added a commit that referenced this pull request Jun 16, 2020
@mdo @XhmikosR
v5: Add role=button cursor in Reboot (#31040)
970f3b3 
* v5: Add role=button cursor in Reboot

Ports the changes from #30562 made in v4.5 and adds them to v5. This replaces #30563 which sought to add this to the utility API, but the v4 PR shifted to implement an accessible solution vs a lone utility.

* Update reboot.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@florianlacreuse florianlacreuse mentioned this pull request Aug 23, 2020
Closed
olsza pushed a commit to olsza/bootstrap that referenced this pull request Oct 3, 2020
@mdo @XhmikosR @olsza
v5: Add role=button cursor in Reboot (twbs#31040)
b3e9053 
* v5: Add role=button cursor in Reboot

Ports the changes from twbs#30562 made in v4.5 and adds them to v5. This replaces twbs#30563 which sought to add this to the utility API, but the v4 PR shifted to implement an accessible solution vs a lone utility.

* Update reboot.md

Co-authored-by: XhmikosR <xhmikosr@gmail.com>
@ffoodd ffoodd mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
css feature v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor pointer Utility
3 participants
@mdo @MartijnCuppens @ffoodd