Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Form validation states capabilities #31757

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Extended Form validation states capabilities #31757

merged 2 commits into from
Dec 17, 2020

Conversation

ydmitry
Copy link
Contributor

@ydmitry ydmitry commented Sep 26, 2020

Part of #31538

@ydmitry ydmitry requested a review from a team as a code owner September 26, 2020 14:19
@ydmitry ydmitry mentioned this pull request Sep 28, 2020
Closed
@ydmitry ydmitry force-pushed the feature/form-validation-state-formulas branch 2 times, most recently from 5d232de to 385b8b6 Compare September 29, 2020 05:52
@ydmitry
Copy link
Contributor Author

ydmitry commented Sep 29, 2020

Updated branch with simplier approach - you can use only required map items or add 1-3 optional items. By default will be used default values from a mixin

ffoodd
ffoodd requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall PR looks good, only docs improvements from my perspective.

scss/_variables.scss Outdated Show resolved Hide resolved
site/content/docs/5.0/migration.md Outdated Show resolved Hide resolved
@ffoodd
Copy link
Member

ffoodd commented Oct 7, 2020

@mdo @MartijnCuppens Would you mind proof-reading the docs here, please? I'm not comfortable enough with copy.

@mdo mdo mentioned this pull request Oct 30, 2020
Closed
@mdo
Copy link
Member

mdo commented Oct 30, 2020

Leaving this one open per my comment at #31538 (comment). I'll swing back around through this for copy soon.

Any chance we can get a rebase?

@ydmitry ydmitry force-pushed the feature/form-validation-state-formulas branch from 5e085f0 to ada0333 Compare November 2, 2020 15:32
@ydmitry
Copy link
Contributor Author

ydmitry commented Nov 2, 2020

Leaving this one open per my comment at #31538 (comment). I'll swing back around through this for copy soon.

Any chance we can get a rebase?

Done, thanks!

@ydmitry ydmitry force-pushed the feature/form-validation-state-formulas branch from ada0333 to dd57bf7 Compare November 2, 2020 16:07
@ydmitry
Copy link
Contributor Author

ydmitry commented Nov 3, 2020

@ffoodd @mdo @MartijnCuppens Hello, branch is up to date to master now, could you please review? Which docs improvements to add?

@ydmitry ydmitry force-pushed the feature/form-validation-state-formulas branch from a356195 to c3475e1 Compare November 3, 2020 11:58
mdo
mdo reviewed Nov 5, 2020
View reviewed changes
scss/mixins/_forms.scss Outdated Show resolved Hide resolved
site/content/docs/5.0/forms/validation.md Outdated Show resolved Hide resolved
site/content/docs/5.0/forms/validation.md Show resolved Hide resolved
site/content/docs/5.0/forms/validation.md Outdated Show resolved Hide resolved
site/content/docs/5.0/forms/validation.md Outdated Show resolved Hide resolved
@ydmitry ydmitry mentioned this pull request Nov 8, 2020
Closed
@ydmitry ydmitry requested a review from mdo November 8, 2020 12:09
ffoodd
ffoodd requested changes Nov 23, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me now, mostly doc comments :)

site/content/docs/5.0/migration.md Outdated Show resolved Hide resolved
ffoodd
ffoodd requested changes Nov 23, 2020
View reviewed changes
site/content/docs/5.0/forms/validation.md Outdated Show resolved Hide resolved
@ydmitry ydmitry requested a review from ffoodd November 24, 2020 07:51
ffoodd
ffoodd approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but Id like other approvals on this :)

XhmikosR
XhmikosR requested changes Dec 16, 2020
View reviewed changes
site/content/docs/5.0/migration.md Outdated Show resolved Hide resolved
@ydmitry ydmitry requested a review from a team as a code owner December 16, 2020 20:00
@ydmitry ydmitry force-pushed the feature/form-validation-state-formulas branch from 7100642 to 63c1c20 Compare December 16, 2020 20:03
@ydmitry ydmitry requested review from XhmikosR and removed request for a team December 16, 2020 20:05
@XhmikosR XhmikosR merged commit 8984255 into twbs:main Dec 17, 2020
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@ffoodd ffoodd ffoodd approved these changes

@MartijnCuppens MartijnCuppens MartijnCuppens approved these changes

@mdo mdo Awaiting requested review from mdo

Assignees
No one assigned
Labels
css v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ydmitry @ffoodd @mdo @XhmikosR @MartijnCuppens @Johann-S