-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended Form validation states capabilities #31757
Extended Form validation states capabilities #31757
Conversation
5d232de
to
385b8b6
Compare
Updated branch with simplier approach - you can use only required map items or add 1-3 optional items. By default will be used default values from a mixin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall PR looks good, only docs improvements from my perspective.
@mdo @MartijnCuppens Would you mind proof-reading the docs here, please? I'm not comfortable enough with copy. |
Leaving this one open per my comment at #31538 (comment). I'll swing back around through this for copy soon. Any chance we can get a rebase? |
5e085f0
to
ada0333
Compare
Done, thanks! |
ada0333
to
dd57bf7
Compare
@ffoodd @mdo @MartijnCuppens Hello, branch is up to date to master now, could you please review? Which docs improvements to add? |
a356195
to
c3475e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good to me now, mostly doc comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but Id like other approvals on this :)
7100642
to
63c1c20
Compare
Part of #31538