util: change isRTL to a function
#32446
Merged
+17
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
main-xmr-js-isRTL
branch
5 times, most recently
from
e41e5e1
to
f5ca90b
Compare
This was referenced Feb 16, 2021
rohit2sharma95
approved these changes
Feb 16, 2021
This allows the bundler to tree-shake the function.
XhmikosR
force-pushed
the
main-xmr-js-isRTL
branch
from
5f6a418
to
c5118c6
Compare
Our CSS is either LTR or RTL.
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the bundler to tree-shake the function.
I wonder if we should cache the function call in the plugins we use
isRTL()?