Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input group validation with custom-file input #33239

Merged
merged 6 commits into from
Oct 21, 2021
Merged

Input group validation with custom-file input #33239

merged 6 commits into from
Oct 21, 2021

Conversation

ffoodd
Copy link
Member

@ffoodd ffoodd commented Mar 2, 2021 •
edited by XhmikosR
Loading

First try to fix #32867 — introduced with #31962.

Simple shot for now, not sure I totally understood what's been done — mostly the nth-last-child(n + 3) part, I'm certainly missing a test case to check this.

Previews:

@ffoodd ffoodd marked this pull request as ready for review March 2, 2021 11:18
@ffoodd ffoodd requested a review from a team as a code owner March 2, 2021 11:18
@XhmikosR XhmikosR requested a review from mdo May 1, 2021 13:53
@ffoodd
Copy link
Member Author

ffoodd commented Sep 1, 2021

Friendly ping @twbs/css-review :)

@XhmikosR
Copy link
Member

XhmikosR commented Oct 8, 2021

@mdo ping

@XhmikosR XhmikosR merged commit e482fbb into v4-dev Oct 21, 2021
@XhmikosR XhmikosR deleted the v4-dev-fod-validated-input-group-with-custom-file branch October 21, 2021 06:00
@XhmikosR XhmikosR mentioned this pull request Oct 21, 2021
Closed
This was referenced May 19, 2022
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request May 19, 2024
Open
@humanbot humanbot mentioned this pull request May 20, 2024
Open
@saurabharch saurabharch mentioned this pull request May 20, 2024
Open
@h-gj h-gj mentioned this pull request May 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 22, 2024
Open
@jelenaCleo jelenaCleo mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 23, 2024
Open
@Mhmonicox Mhmonicox mentioned this pull request May 24, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request May 24, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 20, 2024
Open
@rishisqsh rishisqsh mentioned this pull request Sep 20, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 21, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 21, 2024
Open
@tiff-es tiff-es mentioned this pull request Sep 22, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 22, 2024
Open
@DinGo4DEV DinGo4DEV mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 22, 2024
Open
Open
Open
Open
Open
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 29, 2024
Open
@imsureshbala imsureshbala mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
This was referenced Oct 4, 2024
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 4, 2024
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 30, 2024
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 3, 2024
Open
@leopard1982 leopard1982 mentioned this pull request Nov 3, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdo mdo mdo approved these changes

Assignees
No one assigned
Labels
css v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ffoodd @XhmikosR @mdo