Refactor dropdown's hide functionality #33466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit2sharma95
changed the title
rohit2sharma95
force-pushed
the
rohit/dropdown-hide-refactoring
branch
2 times, most recently
from
fe7018e
to
f2ea4ef
Compare
rohit2sharma95
force-pushed
the
rohit/dropdown-hide-refactoring
branch
from
f2ea4ef
to
b5d02f4
Compare
GeoSot
reviewed
Apr 14, 2021
rohit2sharma95
force-pushed
the
rohit/dropdown-hide-refactoring
branch
from
b5d02f4
to
625a88a
Compare
GeoSot
approved these changes
Apr 14, 2021
Since the class `.show` must be removed
rohit2sharma95
force-pushed
the
rohit/dropdown-hide-refactoring
branch
from
71eb8e9
to
b89f45a
Compare
This was referenced Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share the same code between
hideandclearMenusmethods.Ref: #33451 (comment)