Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footer: fix rel=noopener attribute #33571

Merged
merged 1 commit into from
Apr 9, 2021
Merged

footer: fix rel=noopener attribute #33571

merged 1 commit into from
Apr 9, 2021

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Apr 7, 2021

There's no need to use rel=noopener without target=_blank, but otherwise, it should be used since it's a potential security issue.

There's no need to use `rel=noopener` without target=_blank, but otherwise, it should be used since it's a potential security issue.
@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 7, 2021

BTW @mdo CodeQL and LGTM did catch the missing noopener attribute 😛

image

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants