fix: clicking an item in navbar dropdown should not collapse the dropdown in firefox #33643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpadev
force-pushed
the
fix-dropdown-select-ff
branch
from
5c34a3e
to
3b66ee5
Compare
GeoSot
approved these changes
Apr 15, 2021
alpadev
changed the title
|
@alpadev try to put a minor case to the proper test |
|
Would be nice to have the test indeed, I missed that it was pending. See if you can take care of it later @alpadev :) |
alpadev
added a commit
to alpadev/bootstrap
that referenced
this pull request
Apr 23, 2021
…in the dropdown requested by GeoSot - twbs#33643 (comment)
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #33592
Background
When clicking on an option of a select element the
event.targetin Firefox matches the option element itself unlike the select element like in other browsers.