Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print thead rule #34426

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Remove print thead rule #34426

merged 1 commit into from
Jul 8, 2021

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 6, 2021

The thead rule is safe to remove -- it was a workaround for browsers that didn't conform to this part of the CSS 2.1 spec. (https://www.w3.org/TR/CSS21/tables.html#table-display)
In practice, this meant IE 6 & IE 7.

(thanks to @mattbrundage for this PR upstream for the main.css project (h5bp/main.css#101)

The ``thead`` rule is safe to remove -- it was a workaround for browsers that didn't conform to this part of the CSS 2.1 spec. (https://www.w3.org/TR/CSS21/tables.html#table-display)
In practice, this meant IE 6 & IE 7.

(thanks to @mattbrundage for this PR upstream for the main.css project (h5bp/main.css#101)
@coliff coliff requested a review from a team as a code owner July 6, 2021 02:09
Copy link
Member

@ffoodd ffoodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👌

@XhmikosR XhmikosR merged commit 6c2c14d into twbs:v4-dev Jul 8, 2021
@coliff coliff deleted the patch-1 branch July 8, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants