-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump vnu-jar from 21.6.11 to 21.9.2 #34874
Conversation
Bumps [vnu-jar](https://github.com/validator/validator) from 21.6.11 to 21.9.2. - [Release notes](https://github.com/validator/validator/releases) - [Changelog](https://github.com/validator/validator/blob/main/CHANGELOG.md) - [Commits](validator/validator@21.6.11...21.9.2) --- updated-dependencies: - dependency-name: vnu-jar dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
@patrickhlauke should we just ignore these errors? |
per https://www.w3.org/TR/html-aria/#docconformance
to be cleaner though, it may actually be better to do what the recommendation there is an remove the |
I'm not sure if we should remove the But if you or anyone else wants to take a stab at it and see it in action, fine by me! |
ah, i only looked at a few (where the intent in the docs was clearly to show disabled styling). i think we should do both - set to ignore the warning, but also go through docs example usage of links with |
@patrickhlauke if you are up to make a PR we'll need to backport this. |
for how long will we be backporting doc tweaks to v4? (to be clear, that PR #34886 still needs this check disabled in vnu, as we do give at least one less-than-ideal example that would fail validation) |
We will be supporting v4-dev for some more time for sure. Not sure for how much exactly at this point, though. I don't mind disabling the check, although we won't catch any other cases if we disable the rule. Just pointing it out :) |
but again, we need it disabled because we have a non-ideal example or two (but only a warning, not a hard error) in the docs, even after #34886 is merged) - to show that yes, this can be done, and then explain to the reader the better alternatives |
I know, I meant it mostly that we wouldn't notice any further cases after we ignore this :) |
I disabled it, feel free to edit the JS file to add a comment for future reference :) |
BTW we can always go back to treating warnings as warnings and not errors if you think that's better @patrickhlauke. Otherwise please have a look an maybe add a comment about the new suppression, otherwise we can land this :) |
done |
Bumps vnu-jar from 21.6.11 to 21.9.2.
Release notes
Sourced from vnu-jar's releases.
Commits
2022031
Roll back to latest Jetty 9 (9.4.43.v20210629)be0bcb0
Revert "Add Jetty backend HTTP/2 support (clear text, h2c)"f86bde2
Update css-validator956ed34
Update css-validator11e9ee1
Update Jetty to 10.0.6; javax.servlet-api to 4.0.1b1dd328
Update css-validator93c88bd
Update css-validatorf5384f4
Drop another no-longer-needed filter21ea635
Update css-validator; drop some no-longer-needed filters4d79cda
Dockerfile: Bump unzip versionYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)