Fixed Toast notifications not having background blur. #34968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello guys, I believe the background blur from Toasts was mistakenly removed. The background blur on toasts was available up until bootstrap 4.5.0, in v4.5.1 there were some changes, in which it seems that the background blur got removed. The Bootstrap Documentation for v4.6.0 also mentions that there's an attempt to blur the background under the Toast but there's no such code to do it: https://getbootstrap.com/docs/4.6/components/toasts/#translucent I've noticed this now that we've upgraded to the latest stable 4.6.x version and it looks yuck 😅. Thank you.
|
Just a quick update. I've found out that @mdo has actually issued a commit with the removal of the background filter: b2ef98f#diff-84a7935decf58a2c246ba26d1a02eb8da154e35a704f32fc998921289c028387 If this is decision is permanent, then perhaps the Documentation for v4.5.1 and higher should be updated to reflect that. |
|
Yes, the docs should be updated, not the CSS. Care to open a new PR to address that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I believe the background blur from Toasts was mistakenly removed. The background blur on toasts was available up until bootstrap 4.5.0, in v4.5.1 there were some changes, in which it seems that the background blur got removed.
The Bootstrap Documentation for v4.6.0 also mentions that there's an attempt to blur the background under the Toast but there's no such code to do it: https://getbootstrap.com/docs/4.6/components/toasts/#translucent
I've noticed this now that we've upgraded to the latest stable 4.6.x version and it looks yuck 😅.
Thank you.