Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 dev updates #36430

Merged
merged 3 commits into from
May 26, 2022
Merged

v4 dev updates #36430

merged 3 commits into from
May 26, 2022

Conversation

XhmikosR
Copy link
Member

No description provided.

@XhmikosR XhmikosR added the v4 label May 24, 2022
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from 10f99d4 to 1db9a71 Compare May 24, 2022 07:41
@XhmikosR XhmikosR marked this pull request as ready for review May 24, 2022 07:43
@XhmikosR XhmikosR requested a review from a team as a code owner May 24, 2022 07:43
@XhmikosR XhmikosR requested a review from julien-deramond May 24, 2022 07:44
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the difference with the main branch regarding the ip package version. Let you check if it is normal or if it needs an update :)

package.json Outdated Show resolved Hide resolved
@XhmikosR XhmikosR force-pushed the v4-dev-xmr branch 2 times, most recently from 97e6dae to 70f3ac6 Compare May 26, 2022 04:56
@XhmikosR XhmikosR merged commit 261b418 into v4-dev May 26, 2022
@XhmikosR XhmikosR deleted the v4-dev-xmr branch May 26, 2022 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants