-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: fix some ARIA Authoring Practices Guides broken links #36488
Merged
patrickhlauke
merged 3 commits into
main
from
main-jd-fix-aria-authoring-practices-guide-broken-links
Jun 2, 2022
Merged
Docs: fix some ARIA Authoring Practices Guides broken links #36488
patrickhlauke
merged 3 commits into
main
from
main-jd-fix-aria-authoring-practices-guide-broken-links
Jun 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
commented
Jun 2, 2022
Ah, good point ... I spotted an old link earlier while looking at #36487 and then promptly forgot... |
patrickhlauke
requested changes
Jun 2, 2022
patrickhlauke
requested changes
Jun 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry last nitpick
patrickhlauke
approved these changes
Jun 2, 2022
patrickhlauke
deleted the
main-jd-fix-aria-authoring-practices-guide-broken-links
branch
June 2, 2022 21:10
mwszekely
pushed a commit
to mwszekely/bootstrap
that referenced
this pull request
Jun 8, 2022
* Docs: fix some ARIA Authoring Practices Guides broken link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some ARIA Authoring Practices Guides broken links found in the documentation and tries to improve consistency in the text of those links.
I don't have access to the previous content so I'm not 100% sure that the modification is well
https://www.w3.org/TR/wai-aria-practices/#something
→https://www.w3.org/WAI/ARIA/apg/patterns/something/
.Feel free to comment or directly modify the links.
Note: if merged would need to be backported to v4
Live previews