Add v5.2.0 docs #36769
Add v5.2.0 docs #36769
Conversation
| const markup = `<!doctype html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <link href="https:\/\/cdn.jsdelivr.net\/npm\/bootstrap@5.2.0-beta1\/dist\/css\/bootstrap.min.css" rel="stylesheet"> | ||
| <link href="https:\/\/cdn.jsdelivr.net\/npm\/bootstrap@5.2.0\/dist\/css\/bootstrap.min.css" rel="stylesheet"> | ||
| <link href="https://getbootstrap.com/docs/5.2/assets/css/docs.css" rel="stylesheet"> |
There was a problem hiding this comment.
@julien-deramond why is this here? Doesn't look good practice to load our docs CSS elsewhere and it should not be needed.
There was a problem hiding this comment.
More info in #36637. Without it, lot of examples don't work in StackBlitz. We should try to improve those examples without having to use extra CSS, and so this docs.css, and so this line would disappear.
There was a problem hiding this comment.
Yeah, the docs.css should definitely not be included in StackBlitz. It's dangerous and a bad practice. We should revert it before the v5.2.0 release.
There was a problem hiding this comment.
Bad practice, temporarily yeah. Dangerous, not sure why. IMO it is better for the end user to have examples that work. But if you're strongly against it I understand, your call.
TODO: