Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add more details on accessibility tips #38583

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

hannahiss
Copy link
Contributor

@hannahiss hannahiss commented May 10, 2023

Description

Add more details on accessibility tips: the meaning of an element should be obvious from the content itself, which is usually the visible text, but on the condition of a sufficient color contrast...

Motivation & Context

Accessibility tip is used in many places, and should explain that the text should be not only visible, but perceptible, discernible by all users, meaning a sufficient color contrast.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

This accessibility tip is used in 10 places:

Related issues

@julien-deramond
Copy link
Member

Fixed the Hugo syntax via 96c0331

@julien-deramond julien-deramond marked this pull request as ready for review May 10, 2023 11:15
@mdo mdo merged commit b7e351b into twbs:main Jun 1, 2023
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
* Docs: add more details on accessibility tips

* Docs: add more details on accessibility tips

* Docs: add more details on accessibility tips

* Fix syntax

---------

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants