Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled element tooltip stackblitz #38623

Merged

Conversation

haggerty-ian
Copy link
Contributor

@haggerty-ian haggerty-ian commented May 19, 2023

Description

Fixes the Disabled Element tooltip example for Stackblitz.

Motivation & Context

In the markdown docs for tooltips, some Stackblitz examples don't work (see #36391)

A previous effort was made to fix the tooltip page, but it didn't catch this disabled element example.

For this example, currently Stackblitz loads the code, but does not display the tooltip on hover. These changes make the tooltip load on hover.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @haggerty-ian
Thanks for the PR.
I've added a small modification via d10e4d5 which removes the surrounding <div> which becomes useless.

@XhmikosR XhmikosR merged commit 0d9715e into twbs:main May 31, 2023
@haggerty-ian haggerty-ian deleted the docs-fix-disabled-button-tooltip-stackblitz branch May 31, 2023 15:19
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
* Load js for disabled button tooltip stackblitz

* Remove surrounding useless `<div>`

---------

Co-authored-by: Julien Déramond <juderamond@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants