Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add missing aria-disabled='true' to disabled anchors #38827

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 26, 2023

Description

As mentioned in #38765 (comment) and #38765 (comment), this PR adds aria-disabled="true" to all <a>s with .disabled class. This is a follow-up to #38765.

Hope these use cases all needed aria-disabled="true".

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

#38765

@patrickhlauke
Copy link
Member

👀

@patrickhlauke
Copy link
Member

wonder if we should also give them all tabindex="-1" to make them non-focusable

@ffoodd
Copy link
Member

ffoodd commented Jun 27, 2023

FWIW if they don't have href, they should not be focusable nor mentioned as links.

I think aria-disabled is only useful un ARIA patterns such as tabpanel.

Regarding the linked comments, docs could also be clearer I gues?

@patrickhlauke
Copy link
Member

@ffoodd oops, of course you're right. I just looked at the very first one (indeed the tab example) when I said about tabindex ... my bad. so, let me revise: we should add tabindex="-1" to that js/tests/visual/tab.html tab test

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should add it for pagination as well (disabled class is on the parent but link are still dsiabled to me). Link here
Otherwise, seems fine to me.

@mdo mdo merged commit 3515ac1 into main Jul 6, 2023
@mdo mdo deleted the main-jd-add-missing-aria-disabled-true branch July 6, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants