-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add missing aria-disabled='true'
to disabled anchors
#38827
Conversation
👀 |
wonder if we should also give them all |
FWIW if they don't have I think Regarding the linked comments, docs could also be clearer I gues? |
@ffoodd oops, of course you're right. I just looked at the very first one (indeed the tab example) when I said about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should add it for pagination as well (disabled class is on the parent but link are still dsiabled to me). Link here
Otherwise, seems fine to me.
Description
As mentioned in #38765 (comment) and #38765 (comment), this PR adds
aria-disabled="true"
to all<a>
s with.disabled
class. This is a follow-up to #38765.Hope these use cases all needed
aria-disabled="true"
.Type of changes
Checklist
npm run lint
)Live previews
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/card/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/dropdowns/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/list-group/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/navbar/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/navs-tabs/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/components/card/placeholders/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/blog/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/blog-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/carousel/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/carousel-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/cheatsheet/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/cheatsheet-rtl/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-bottom/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-fixed/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbar-static/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/navbars/
https://deploy-preview-38827--twbs-bootstrap.netlify.app/docs/5.3/examples/sticky-footer-navbar/
Related issues
#38765