-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use box-shadow CSS vars instead of Sass vars in assets and variables #38976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louismaximepiton
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It feels safer than border-width
since we don't modify the CSS vars. LGTM!
mdo
approved these changes
Aug 5, 2023
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses
--bs-box-shadow*
CSS vars instead of$box-shadow*
Sass vars in ourscss/_variables.scss
and oursite/assets/scss/_*scss
in the same spirit of what we can do with--bs-border-width
for instance.In order to test it for some use cases, don't forget to enable locally
$enable-shadows
to see the shadows, or to keep it disabled to check for non-regressions.There shouldn't be anything to mention in the migration guide or that can be breaking for folks. It should be safe to be embedded even in a dot version.
Motivation & Context
Following up #38816 and the following comment #38816 (review).
Type of changes
Checklist
npm run lint
)Live previews