Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop .table-light from table foot example #39320

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Drop .table-light from table foot example #39320

merged 1 commit into from
Oct 23, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 21, 2023 •
edited by louismaximepiton
Loading

Description

As mentioned in #39319, users could expect to see .table-light in the code part. Since this part is rather to show the table foot, I've dropped the .table-light class from the rendering part. It makes it consistent with the other examples and doesn't "pollute" the code part with an extra class.

Type of changes

  • Doc enhancement (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #39319

@julien-deramond julien-deramond mentioned this pull request Oct 21, 2023
Closed
3 tasks
@julien-deramond julien-deramond marked this pull request as ready for review October 21, 2023 10:51
@julien-deramond julien-deramond merged commit d58e86e into main Oct 23, 2023
12 checks passed
@julien-deramond julien-deramond deleted the main-jd-fix-table-foot-code-example branch October 23, 2023 17:21
priyashpatil pushed a commit to priyashpatil/bootstrap that referenced this pull request Nov 8, 2023
@julien-deramond @priyashpatil
Docs: drop .table-light from table foot example (twbs#39320)
8358c76
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
@julien-deramond @romankupchak93
Docs: drop .table-light from table foot example (twbs#39320)
2cbdea2
@damian-snyk damian-snyk mentioned this pull request Apr 19, 2024
Open
@CGrabda CGrabda mentioned this pull request May 17, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 18, 2024
Open
@lukegeor lukegeor mentioned this pull request May 18, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
This was referenced May 19, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 19, 2024
Open
@Identian Identian mentioned this pull request May 20, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 21, 2024
Open
@Hamberfim Hamberfim mentioned this pull request May 21, 2024
Merged
@V1CTORY360 V1CTORY360 mentioned this pull request May 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request May 23, 2024
Open
This was referenced May 24, 2024
Open
Open
@devcurt696 devcurt696 mentioned this pull request May 24, 2024
Open
@BeyondMaxim BeyondMaxim mentioned this pull request May 24, 2024
Open
@suryaelidanto suryaelidanto mentioned this pull request May 24, 2024
Open
@nejidevelops nejidevelops mentioned this pull request May 24, 2024
Open
@Guiguiiz92 Guiguiiz92 mentioned this pull request May 24, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 29, 2024
Open
@DeFiTON DeFiTON mentioned this pull request Sep 30, 2024
Open
@lisagorewitdecker lisagorewitdecker mentioned this pull request Sep 30, 2024
Merged
@YnnusAsamal YnnusAsamal mentioned this pull request Sep 30, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Sep 30, 2024
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 1, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 1, 2024
Open
@Akhamesra Akhamesra mentioned this pull request Oct 2, 2024
Open
This was referenced Oct 2, 2024
Open
Open
@YnnusAsamal YnnusAsamal mentioned this pull request Oct 3, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 4, 2024
Open
@jtprogru jtprogru mentioned this pull request Oct 5, 2024
Open
@Gutts-n Gutts-n mentioned this pull request Oct 5, 2024
Open
@Kimahari Kimahari mentioned this pull request Oct 5, 2024
Open
This was referenced Oct 5, 2024
Open
Open
This was referenced Oct 12, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 13, 2024
Open
This was referenced Oct 15, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 20, 2024
Open
@Sarrac3873 Sarrac3873 mentioned this pull request Oct 22, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Oct 27, 2024
Open
This was referenced Oct 29, 2024
Open
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 3, 2024
Open
@Arrhenius09 Arrhenius09 mentioned this pull request Nov 6, 2024
Open
@RatanaSenpai RatanaSenpai mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs v5
Projects
No open projects
v5.3.3
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table foot - Incorrect documentation
2 participants
@julien-deramond @louismaximepiton