-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop --bs-accordion-btn-focus-border-color
and deprecate $accordion-button-focus-border-color
#39560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-button-focus-border-color`
louismaximepiton
approved these changes
Jan 3, 2024
mdo
approved these changes
Jan 3, 2024
This was referenced May 19, 2024
This was referenced May 24, 2024
This was referenced Oct 2, 2024
This was referenced Oct 5, 2024
This was referenced Oct 12, 2024
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in https://github.com/orgs/twbs/discussions/39559, accordion button's border width is set to 0 and is never changed afterwards. The focus state is handled by a box-shadow.
Based on these elements, this PR:
border-color
rule from the focused.accordion-button
--bs-accordion-btn-focus-border-color
$accordion-button-focus-border-color
This might be referenced in the blog post.
Type of changes
Checklist
npm run lint
)Live previews
Related issues