Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite.md #39592

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Update vite.md #39592

merged 4 commits into from
Feb 13, 2024

Conversation

bertday
Copy link
Contributor

@bertday bertday commented Jan 21, 2024

Description

A quick commit to fix a few small typos/style issues in the Vite tutorial.

Motivation & Context

Improves style and readability in the Vite docs.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fix some minor style issues in Vite tutorial
@julien-deramond
Copy link
Member

julien-deramond commented Jan 30, 2024

Thanks for the PR @rbrtmrtn I'll let our native English speakers confirm that this fix is correct (ping @mdo or @patrickhlauke) :)
However, if we merge it, the exact same modifications should be applied to parcel.md and webpack.md for consistency; they use the same sentences.

Copy link
Member

@mdo mdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. @rbrtmrtn Can you update the other guides too?

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I applied the same modifications to the Parcel and Webpack guides via bd5cf86.

@julien-deramond julien-deramond merged commit cb7467b into twbs:main Feb 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants