Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: change wording of single/split danger buttons #40689

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

2af
Copy link
Contributor

@2af 2af commented Aug 3, 2024

Incorrect display word in example

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Incorrect display word in example
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @2af
Sounds better this way, since <!-- Example split danger button --> is actually displayed into the copy/pastable code.

@julien-deramond julien-deramond changed the title Update dropdowns.md Docs: change wording of single/split danger buttons Aug 5, 2024
@julien-deramond julien-deramond merged commit 4e954ea into twbs:main Aug 7, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants