Docs: Update modal min-height inline style #40870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on very large screens (e.g. 4K monitors) the value `min-height: 1500px` doesn't show scrollbars as all the content fits on screen at once. Changing it to `min-height: 100vh` will ensure it always requires scrolling. (you can test this by zooming out when viewing docs)
julien-deramond
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Smart change, thanks @coliff 👌
I tested it across multiple browsers, both at normal zoom and zoomed out, and everything works smoothly with no regressions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation & Context
RE: https://getbootstrap.com/docs/5.3/components/modal/#scrolling-long-content
on very large screens (e.g. 4K monitors) the value
min-height: 1500pxdoesn't show scrollbars as all the content fits on screen at once. Changing it tomin-height: 100vhwill ensure it always requires scrolling. (you can test this by zooming out when viewing docs)Type of changes
Checklist
npm run lint)Live previews