Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: working with Sass 1.79.4 #40925

Closed
wants to merge 1 commit into from

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 9, 2024

Description

  • Updated Library version
  • Implementing myself the red, green, and blue` function that are missing from Sass 1.79.4 with all the errors I could possibly do and no tests
  • Adapting tests

Motivation & Context

Sass 1.79.4 deprecation warnings.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@louismaximepiton louismaximepiton force-pushed the main-lmp-handle-sass-1.79-warnings branch from 20b3857 to eff1f20 Compare October 9, 2024 07:25
@louismaximepiton
Copy link
Member Author

We probably don't want and won't merge this.

@louismaximepiton louismaximepiton deleted the main-lmp-handle-sass-1.79-warnings branch October 9, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant