Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the --version option to the CLI #133

Merged
merged 5 commits into from
Feb 13, 2023
Merged

Add the --version option to the CLI #133

merged 5 commits into from
Feb 13, 2023

Conversation

Nour-Mws
Copy link
Collaborator

@Nour-Mws Nour-Mws commented Feb 9, 2023 •
edited
Loading

Closes #126

@Nour-Mws Nour-Mws requested review from jherland and mknorps February 9, 2023 17:28
@Nour-Mws Nour-Mws added this to the First public release milestone Feb 9, 2023
jherland
jherland approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite different from what I expected, but I don't think it's wrong, and I like the fact that we don't have to repeat the version number from pyproject.toml anywhere else!

fawltydeps/main.py Outdated Show resolved Hide resolved
fawltydeps/main.py Show resolved Hide resolved
fawltydeps/main.py Outdated Show resolved Hide resolved
@Nour-Mws Nour-Mws force-pushed the nour/add-version-to-cli branch 2 times, most recently from 7113a2f to 5dad899 Compare February 10, 2023 15:02
jherland
jherland reviewed Feb 10, 2023
View reviewed changes
fawltydeps/main.py Outdated Show resolved Hide resolved
@Nour-Mws Nour-Mws force-pushed the nour/add-version-to-cli branch from 039f240 to e9336e4 Compare February 10, 2023 17:51
jherland
jherland approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@jherland jherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to 🚀, modulo some nitpicking on the new function. 😃

fawltydeps/main.py Outdated Show resolved Hide resolved
@Nour-Mws Nour-Mws force-pushed the nour/add-version-to-cli branch from 1601284 to 68ed91d Compare February 13, 2023 08:31
@Nour-Mws Nour-Mws force-pushed the nour/add-version-to-cli branch from 68ed91d to c280b71 Compare February 13, 2023 08:42
@Nour-Mws Nour-Mws merged commit 6e45ed1 into main Feb 13, 2023
@Nour-Mws Nour-Mws deleted the nour/add-version-to-cli branch February 13, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mknorps mknorps mknorps approved these changes

@jherland jherland jherland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
First public release
Development

Successfully merging this pull request may close these issues.

Add --version flag to CLI
3 participants
@Nour-Mws @jherland @mknorps