Get rid of most generated variables (#1679)

* add Closure node to AST * Implement non-looping partial eq for Term * Fix contracts app * Use closure within records as well everywhere * Fix double closurization * Fix subst to update closurized attrs * Fix type eq for closures * More typecheck eq * More work + formatting * Get rid of share normal form + move Closurize to dedicated mod * Accept new snapshots (error msg less noisy) * Fix compilation warnings * Fix various small TODOs left * Cleaning comments and debug println * Update documentation for new closurize approach * Apply suggestions from code review Co-authored-by: jneem <joeneeman@gmail.com> * Update core/src/closurize.rs Co-authored-by: jneem <joeneeman@gmail.com> * Fix various code comments * Post-rebase fixup * Formatting + post-rebase fixup * Restore array contract dedup fix messed up by rebases --------- Co-authored-by: jneem <joeneeman@gmail.com>
tweag · Oct 16, 2023 · 2a727ba · 2a727ba
1 parent 859293a
commit 2a727ba
Show file tree

Hide file tree

Showing 27 changed files with 999 additions and 998 deletions.
diff --git a/cli/tests/snapshot/snapshots/snapshot__eval_stderr_array_at_empty_array.ncl.snap b/cli/tests/snapshot/snapshots/snapshot__eval_stderr_array_at_empty_array.ncl.snap
@@ -13,11 +13,6 @@ error: contract broken by the caller of `at`: invalid array indexing
   3 │ std.array.at 0 []
     │                -- evaluated to this expression
     │
-    ┌─ <unknown> (generated by evaluation):1:1
-    │
-  1 │ [  ]
-    │ ---- evaluated to this value
-    │
     = Can't index into an empty array
 
 note: 

diff --git a/cli/tests/snapshot/snapshots/snapshot__eval_stderr_array_at_out_of_bound.ncl.snap b/cli/tests/snapshot/snapshots/snapshot__eval_stderr_array_at_out_of_bound.ncl.snap
@@ -13,11 +13,6 @@ error: contract broken by the caller of `at`: invalid array indexing
   3 │ std.array.at 2 [1]
     │                --- evaluated to this expression
     │
-    ┌─ <unknown> (generated by evaluation):1:1
-    │
-  1 │ [ %262 ]
-    │ -------- evaluated to this value
-    │
     = Expected an array index between 0 and 0 (included), got 2
 
 note: 

diff --git a/cli/tests/snapshot/snapshots/snapshot__eval_stderr_destructuring_closed_fail.ncl.snap b/cli/tests/snapshot/snapshots/snapshot__eval_stderr_destructuring_closed_fail.ncl.snap
@@ -10,11 +10,6 @@ error: contract broken by a value: extra field `b`
   │     │      
   │     expected type
   │
-  ┌─ <unknown> (generated by evaluation):1:1
-  │
-1 │ { a = 1, b = 2, }
-  │ ----------------- evaluated to this value
-  │
   = Have you misspelled a field?
   = The record contract might also be too strict. By default, record contracts exclude any field which is not listed.
     Append `, ..` at the end of the record contract, as in `{some_field | SomeContract, ..}`, to make it accept extra fields.

diff --git a/...ests/snapshot/snapshots/snapshot__eval_stderr_record_forall_constraints_contract.ncl.snap b/...ests/snapshot/snapshots/snapshot__eval_stderr_record_forall_constraints_contract.ncl.snap
@@ -9,11 +9,6 @@ error: contract broken by the caller: field not allowed in tail: `x`
   │                   -------                                                             --------- evaluated to this expression
   │                   │                                                                    
   │                   expected type of the argument provided by the caller
-  │
-  ┌─ <unknown> (generated by evaluation):1:1
-  │
-1 │ { x = 0, }
-  │ ---------- evaluated to this value
 
 note: 
   ┌─ [INPUTS_PATH]/errors/record_forall_constraints_contract.ncl:3:58