Add primops to access the current diagnostic of a label #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit introduced a more fine-grained interface for contract labels, in order to customize error diagnostic. This PR adds the Nickel primops that make this interface accessible to usercode.
Updates the contract stdlib to expose the new label primop introduced in a previous commit. Renames existing function accordingly. Get rid of the `%tag%` primop, now replaced by `%with_message%`.
Co-authored-by: Oghenevwogaga Ebresafe <gaga.ebresafe@tweag.io>
vkleen
approved these changes
Mar 8, 2023
Noice 😎 |
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous PR (#1152) introduced a more fine-grained interface for contract labels, in order to customize error diagnostic. This PR add the Nickel primops to make this interface accessible to usercode, as well as the corresponding stdlib functions.
Content
label_with_message,label_with_notes,label_append_note,label_push_diagprimops, calling the corresponding methods onLabelcontract.labelsubmodule%tag%andcontract.tag, superseded by%label_with_message%andcontract.label.with_messagecontract.blame_withtocontract.blame_with_messagecontract.applyto automatically call%label_push_diag%. This means thatcontract.applybecomes the implicit split point between a parent contract and children subcontracts: it will stack any previously set custom diagnostic, which will save it from further modifications. Later calls to e.g.contract.label.with_error_messagewill modify a new, fresh diagnostic. All stacked diagnostics are printed during error reporting, in reverse order.