Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic when parsing record type with field path #1325

Merged
merged 1 commit into from
May 26, 2023

Commits on May 26, 2023

  1. Prevent panic when parsing record type with field path

    Nickel does not support record types with field paths. i.e. while this
    is a valid type:
    
    ```
    { x : { y : String } }
    ```
    
    this is not:
    
    ```
    { x.y : String }
    ```
    
    However, at some point rather than raising the appropriate error here,
    we started panicking. This commit fixes that by checking that a field's
    path only contains a single element before deciding whether to allow
    it in a record type.
    Matthew Healy committed May 26, 2023
    Configuration menu
    Copy the full SHA
    520d4cb View commit details
    Browse the repository at this point in the history