Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LSP panic when importing JSON #1382

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Fix LSP panic when importing JSON #1382

merged 5 commits into from
Jun 20, 2023

Commits on Jun 19, 2023

  1. Fix LSP panic when importing JSON

    Nickel terms imported from a JSON file currently don't have any position
    set, which was making the LSP panic. This commits stores the original
    input format alongside cached terms, and makes this information
    available to the public API. The LSP now uses it and abort any usage
    analysis when the term comes from an external import.
    yannham committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    c251121 View commit details
    Browse the repository at this point in the history
  2. Add regression test for LSP external imports

    This commit adds a test to the LSP test suite to check that importing an
    external format doesn't make it crash as it used to.
    yannham committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    89b151c View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    ebc8f9a View commit details
    Browse the repository at this point in the history
  2. CachedTerm -> TermEntry

    yannham committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    97d3a07 View commit details
    Browse the repository at this point in the history
  3. Only make one hashmap access during linearization

    Add an helper to `cache` to retrieve both the input format and a cached
    term from the cache with only one hashmap access.
    
    This commit also updates some related comments inside the code of the
    LSP, which were not up-to-date anymore.
    yannham committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    581a0c8 View commit details
    Browse the repository at this point in the history