Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two examples: imports and foreach pattern #1387

Merged
merged 10 commits into from
Jul 6, 2023
Merged

Add two examples: imports and foreach pattern #1387

merged 10 commits into from
Jul 6, 2023

Conversation

mipmip
Copy link
Contributor

@mipmip mipmip commented Jun 20, 2023

No description provided.

yannham
yannham reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing (again)! That sounds like a cool addition. As a nitpick I would simply use imports instead of various-imports, but that's not very important.

examples/foreach-pattern/README.md Outdated Show resolved Hide resolved
examples/various-imports/README.md Outdated Show resolved Hide resolved
examples/various-imports/data_nickel_properties.ncl Outdated Show resolved Hide resolved
@yannham
Copy link
Member

yannham commented Jul 5, 2023

I've run topiary on the new examples, them not being formatted was failing the CI.

@yannham yannham enabled auto-merge July 5, 2023 16:04
@mipmip
Copy link
Contributor Author

mipmip commented Jul 6, 2023

Can I do something?

vkleen
vkleen approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@vkleen vkleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is just missing test annotations in the examples. We also tend to forget about those from time to time 😅

examples/foreach-pattern/foreach-pattern-on-import.ncl Show resolved Hide resolved
examples/foreach-pattern/foreach-pattern.ncl Show resolved Hide resolved
examples/imports/data_nickel_properties.ncl Show resolved Hide resolved
examples/imports/imports.ncl Show resolved Hide resolved
vkleen
vkleen reviewed Jul 6, 2023
View reviewed changes
examples/imports/imports.ncl Outdated Show resolved Hide resolved
vkleen
vkleen reviewed Jul 6, 2023
View reviewed changes
examples/imports/imports.ncl Outdated Show resolved Hide resolved
@yannham yannham added this pull request to the merge queue Jul 6, 2023
Merged via the queue into tweag:master with commit d918a7c Jul 6, 2023
@chenrui333 chenrui333 mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneem jneem jneem left review comments

@vkleen vkleen vkleen approved these changes

@yannham yannham yannham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mipmip @yannham @jneem @vkleen