Full vscode extension #1405
Full vscode extension #1405
Conversation
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
There was a problem hiding this comment.
Without a LICENSE we get a warning.
| "name": "nls", | ||
| "description": "Nickel Language Server", | ||
| "name": "vscode-nickel", | ||
| "description": "Nickel Language", |
There was a problem hiding this comment.
This will be the title (name) and description in the vscode marketplace.
There was a problem hiding this comment.
After a quick look at the VSCode market place, many extensions (not necessarily languages) seem to follow the vscode-xxx naming scheme, many language extensions don't, but that name sounds reasonable 👍
There was a problem hiding this comment.
Ah, there's also displayName as name can't contain spaces. Do we want something like "Nickel Language" instead? And add some more details in "description“?
There was a problem hiding this comment.
Hm, that could be a good idea. But this can be done is a subsequent PR as well, so I'm in for merging this one first, as it's self-contained and in good shape 🙂
| args: traceFile ? ["--trace", traceFile.toString()] : [], | ||
| transport: TransportKind.stdio, |
There was a problem hiding this comment.
Removed this as it was trying to pass --stdin to nls.
| src = pkgs.lib.cleanSource ./lsp/client-extension; | ||
|
|
||
| buildPhase = '' | ||
| export HOME="$TMPDIR" |
There was a problem hiding this comment.
It's trying to create .yarn in HOME. There's probably a better way to fix this but this works for now.
szlend
force-pushed
the
full-vscode-extension
branch
3 times, most recently
from
f75b67d
to
606f243
Compare
szlend
force-pushed
the
full-vscode-extension
branch
from
606f243
to
436df70
Compare
There was a problem hiding this comment.
Many thanks for this @szlend ! It's fine by me, I just don't approve yet so that you can take a look at the review comments and decide what to do with them. When it's done, please ping me or re-request my review and I'll merge it.
| "name": "nls", | ||
| "description": "Nickel Language Server", | ||
| "name": "vscode-nickel", | ||
| "description": "Nickel Language", |
There was a problem hiding this comment.
After a quick look at the VSCode market place, many extensions (not necessarily languages) seem to follow the vscode-xxx naming scheme, many language extensions don't, but that name sounds reasonable 👍
| }, | ||
| "strings_interpolation": { | ||
| "name": "string.interpolated", | ||
| "begin": "m%\"$", |
There was a problem hiding this comment.
As a note, this won't work with variable length string delimiters: m%%\" some string "%%, but honestly we can add this in a second step. To do that properly we need to share some state between begin, end, and patterns, which would be set by begin (and is the number of % in the opening delimiter).
There was a problem hiding this comment.
Yeah I'm not too familiar with the tmLanguage spec. I added a fix that should at least handle the start and end of variable length string delimiters.
szlend
force-pushed
the
full-vscode-extension
branch
from
436df70
to
4b779cd
Compare
szlend
force-pushed
the
full-vscode-extension
branch
from
4b779cd
to
5ece996
Compare
Ported from: https://github.com/szlend/vscode-nickel