Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pretty printer correctly escape field names #1410

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Make the pretty printer correctly escape field names #1410

merged 2 commits into from
Jun 29, 2023

Commits on Jun 28, 2023

  1. Make the pretty printer correctly escape field names 

    Previously, the pretty printer relied on `Ident::label_quoted` for
printing record field names. This function blindly placed an identifier
between quotes if it was deemed necessary. This produces incorrect
results if the identifier label itself contains quotes, for example.
    @vkleen
    vkleen committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    b92d48f View commit details
    Browse the repository at this point in the history

  2. Move Ident::label_quoted into pretty as a freestanding function

    @vkleen
    vkleen committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    78a10ed View commit details
    Browse the repository at this point in the history