Improve query inteface #1447
Merged
Improve query inteface #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the query command of the REPL would accept a first argument that could be a record access chain, followed by a second one which could also be a field path. This means that, for querying a given path `foo.bar.baz.blo`, there are 3 different but equivalent query invocations: - :query foo bar.baz.blo - :query foo.bar baz.blo - :query foo.bar.baz blo Moreover, `:query foo.bar.baz.blo` without a second argument wouldn't fail but pretend that there are no metadata, even if there are. This commit simplify the overall interfaceo of the query command by just accepting one argument which is a field path.
vkleen
approved these changes
Jul 11, 2023
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1446.
Previously, the query command of the REPL would accept a first argument that could be a record access chain, followed by a second one which could also be a field path. This means that, for querying a given path
foo.bar.baz.blo, there are 3 different but equivalent query invocations::query foo bar.baz.blo:query foo.bar baz.blo:query foo.bar.baz bloMoreover,
:query foo.bar.baz.blowithout a second argument wouldn't fail but pretend that there are no metadata, even if there are.This PR simplifies the overall interface of the query command by just accepting one argument which is a field path.