Make the lexer accept scientific notation #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannham
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Might be worth a documentation update. The fact that we are currently parsing 1e6 as 1 e6 is both useless and should be considered a bug in the current implementation (not very pressing, but still), so I don't think it should be part of the informal backward compatibility guarantee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we were alread using
malachite's scientific notation parser for parsing numbers, the only thing stopping #1361 was the lexer not supporting scientific notation. This would technically be a breaking change, since previouslyf 1e6would be parsed asfapplied to the number1and the variablee6, while now it would be parsed asfapplied to one million. I hope that nobody relies on this behaviour but it's worth considering, given our (informal, for now) stability guarantee.