[Refactor] Move unify and variants into their own trait
#1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
approved these changes
Jul 21, 2023
yannham
force-pushed
the
refactor/typecheck-unif-module
branch
from
83603a6
to
79db528
Compare
yannham
force-pushed
the
refactor/unify-trait
branch
from
124929c
to
be1d408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement unification on three different types (types, record rows and enum rows). Instead of having three free-standing functions
unify_xxx, this PR creates oneUnifytrait and implement it for those types. As it's implemented onself, it also re-order the arguments to make more sense, such that the unified type are in sequence in the method call (the target type is the first argument).Beside the trait definition and argument re-ordering, this PR is just moving code around.