Import YAML files containing multiple documents as arrays #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jneem
approved these changes
Aug 3, 2023
| let mut terms = de | ||
| .map(|de| { | ||
| RichTerm::deserialize(de) | ||
| .map(attach_pos) |
There was a problem hiding this comment.
It would make more sense to attach the sub-span corresponding to the single document, I guess. Doesn't seem like this can be easily extracted from serde_yaml, though...
There was a problem hiding this comment.
Yeah, I guess that's also the reason that the subterms of a term imported from something other than Nickel don't carry positions. I wonder if that breaks some assumptions in the evaluator...
| // we deserialize the file as an array. | ||
| let de = serde_yaml::Deserializer::from_str(self.files.source(file_id)); | ||
| let mut terms = de | ||
| .map(|de| { |
There was a problem hiding this comment.
TIL that serde_yaml::Deserializer implements Iterator<Item=serde_yaml::Deserializer> 🙀
vkleen
force-pushed
the
feat/multiple-yaml-documents
branch
from
deec759
to
140108f
Compare
For example, in Kubernetes deployments it is common practice to package multiple YAML documents into a single file. For processing such files with Nickel we need to support importing multiple YAML documents from a single file. The concern with this is: how does such a file fit into Nickel's data model? Importing it as an array of Nickel values felt most reasonable to me. At the same time, a YAML file containing a single document should still be transparently serialized as that document, not as a single element array.
vkleen
force-pushed
the
feat/multiple-yaml-documents
branch
from
140108f
to
505105b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, in Kubernetes deployments it is common practice to package multiple YAML documents into a single file. For processing such files with Nickel we need to support importing multiple YAML documents from a single file. The concern with this is: how does such a file fit into Nickel's data model? Importing it as an array of Nickel values felt most reasonable to me. At the same time, a YAML file containing a single document should still be transparently serialized as that document, not as a single element array.