Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Nickel CLI #1502

Merged
merged 11 commits into from
Aug 8, 2023
Merged

Refactor the Nickel CLI #1502

merged 11 commits into from
Aug 8, 2023

Commits on Aug 7, 2023

  1. Refactor the Nickel CLI structure

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    cdb2e5f View commit details
    Browse the repository at this point in the history

  2. Add an Error enum for the CLI

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6643ffe View commit details
    Browse the repository at this point in the history

  3. Restore the previous user-facing interface

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    eea3b8a View commit details
    Browse the repository at this point in the history

  4. Make clippy happy

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    bc5033b View commit details
    Browse the repository at this point in the history

  5. Restore nickel format CLI behaviour

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    e4360af View commit details
    Browse the repository at this point in the history

  6. Change command options naming

    @vkleen
    vkleen committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    6e44778 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Properly respect feature flags

    @vkleen
    vkleen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    486a259 View commit details
    Browse the repository at this point in the history

  2. WithProgram -> ReportWithProgram

    @vkleen
    vkleen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    7872a35 View commit details
    Browse the repository at this point in the history

  3. Remove the unecessary Files struct for now

    @vkleen
    vkleen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    0dd10ee View commit details
    Browse the repository at this point in the history

  4. ReportWithProgram -> ResultErrorExt

    @vkleen
    vkleen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    aeebbba View commit details
    Browse the repository at this point in the history

  5. Suggestions from code review

    @vkleen
    vkleen committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    1bb6384 View commit details
    Browse the repository at this point in the history