Fix problem with Program::parse() #1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Program::parse()
was callingImportResolver::get()
which assumed that as anImportResolver
, we can only get terms when all the imports are resolved, so it had adebug_assert!()
to ensure this. In this case, we are only parsing the file and returning its AST, so we can get theterms
field of theCache
and callget()
on that.We had discussed a much more complicated solution that essentially amounted to this, plus a refactor of how
ImportResolver
works. But as I was implementing it started seeming less like a good idea, and also I realized not necessary to solve this problem. We can revisit that refactor, but for now this solves the problem.