Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display icon for nickel file in vscode explorer #1556

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Conversation

suimong
Copy link
Contributor

@suimong suimong commented Aug 30, 2023

I've taken the liberty to reuse the logo file within the vscode extension as the icon for nickel files displayed in vscode explorer directory tree. Currently there's no distinction between light & dark mode, nevertheless the official logo is reasonably visible under both.

Dark mode:

image

Light mode:

image

Copy link
Member

@yannham yannham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution!

@yannham yannham enabled auto-merge August 30, 2023 07:45
@yannham yannham added this pull request to the merge queue Aug 30, 2023
Merged via the queue into tweag:master with commit c984a4a Aug 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants