Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete check of record row constraints #1558

Merged
merged 1 commit into from
Sep 1, 2023

Commits on Sep 1, 2023

  1. Fix incomplete check of row constraints

    In an attempt to free the allocation of the constraints of a record row
    unification variable that is being assigned to some record rows, the
    code checking that row constraints are satisfied was removing the
    constraints from the global state. Since rows are defined as linked
    list, if the constraint wasn't violated on the first row, this function
    would recursively call itself. But then the subsequent recursive calls
    would try to get the constraints from the state again, to only find an
    empty set constraints, as it has been removed just before. The function
    thus wouldn't detect constraint violations happening in the tail of the
    record rows.
    
    This patch defines a subfunction which passes the initial constraints
    along recursive calls, such that they aren't lost during recursion,
    instead of trying to get them from the state again at each recursive
    call.
    yannham committed Sep 1, 2023
    Configuration menu
    Copy the full SHA
    459c042 View commit details
    Browse the repository at this point in the history