Implement curried dot operator #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
reviewed
Sep 6, 2023
core/src/parser/grammar.lalrpop
Outdated
| @@ -673,6 +673,9 @@ MatchCase: MatchCase = { | |||
|
|
|||
| // Infix operators by precedence levels. Lowest levels take precedence over | |||
| // highest ones. | |||
| InfixBOp1: BinaryOp = { | |||
There was a problem hiding this comment.
Suggested change
| InfixBOp1: BinaryOp = { | |
| InfixBOpAccess: BinaryOp = { |
A minor nitpick, but the other InfixBOp productions are named according to their operator precedence in InfixExpr. In fact, I'm tempted to say, that it would be better to put a case like
<l: @L> "." <r: @R> =>
InfixOp::from(BinaryOp::DynAccess())
.eta_expand(mk_pos(src_id, l, r)),
into the CurriedOp production, because . is never parsed as a generic infix operator. It rather has its own parsing rules as part of RecordOperationChain.
There was a problem hiding this comment.
Makes sense. Moved implementation inside CurriedOp.
move implementation inside CurriedOp
yannham
approved these changes
Sep 6, 2023
suimong
added a commit
to suimong/nickel
that referenced
this pull request
Sep 17, 2023
* display icon for nickel file in vscode explorer * implemented with DynAccess. * added tests. * Update grammar.lalrpop move implementation inside CurriedOp --------- Co-authored-by: Ben Yang <ben@ya.ng>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per #1568 , so that
(.) field recordworks. It is very pleasant to see that all it takes is just adding four lines of code, and everything works, including the language server. Thank you @yannham & @vkleen for the kind help.