Cache more #1580
Merged
Cache more #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
reviewed
Sep 6, 2023
Radvendii
force-pushed
the
cache-more
branch
from
775c5ba
to
d8fa0cd
Compare
vkleen
reviewed
Sep 6, 2023
yannham
approved these changes
Sep 7, 2023
suimong
pushed a commit
to suimong/nickel
that referenced
this pull request
Sep 17, 2023
* cache most of the work even if rev changes * longer string for more reliable search. * more recognizable dummyRev * nickel-lang-static needs env * appease nixpkgs-fmt * copy meta to new derivation * add comment
YorikSar
added a commit
that referenced
this pull request
Sep 27, 2023
#1580 introduced patching of resulting binary in a separate derivation that ends up with bad (or missing) code signature which prevents it from running: % nix run zsh: killed nix run and Console.app revealing the reason: Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid)) Exception Codes: UNKNOWN_0x32 at 0x00000001054e4199 Exception Codes: 0x0000000000000032, 0x00000001054e4199 This change uses autoSignDarwinBinariesHook to sign the result that seems to fix the problem.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
#1580 introduced patching of resulting binary in a separate derivation that ends up with bad (or missing) code signature which prevents it from running: % nix run zsh: killed nix run and Console.app revealing the reason: Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid)) Exception Codes: UNKNOWN_0x32 at 0x00000001054e4199 Exception Codes: 0x0000000000000032, 0x00000001054e4199 This change uses autoSignDarwinBinariesHook to sign the result that seems to fix the problem.
YorikSar
added a commit
that referenced
this pull request
Sep 29, 2023
#1580 introduced patching of resulting binary in a separate derivation that ends up with bad (or missing) code signature which prevents it from running: % nix run zsh: killed nix run and Console.app revealing the reason: Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid)) Exception Codes: UNKNOWN_0x32 at 0x00000001054e4199 Exception Codes: 0x0000000000000032, 0x00000001054e4199 This change uses autoSignDarwinBinariesHook to sign the result that seems to fix the problem.
yannham
pushed a commit
that referenced
this pull request
Sep 29, 2023
#1580 introduced patching of resulting binary in a separate derivation that ends up with bad (or missing) code signature which prevents it from running: % nix run zsh: killed nix run and Console.app revealing the reason: Exception Type: EXC_BAD_ACCESS (SIGKILL (Code Signature Invalid)) Exception Codes: UNKNOWN_0x32 at 0x00000001054e4199 Exception Codes: 0x0000000000000032, 0x00000001054e4199 This change uses autoSignDarwinBinariesHook to sign the result that seems to fix the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now in the nix build we set the
NICKEL_NIX_BUILD_REVenvironment variable, which affects the string printed bynickel --version. However, this invalidates the cache on every commit (and when building dirty), even if nothing in the code was changed it has to be recompiled in CI, and also locally if the repo is dirty.This change puts a static string in that spot, which can then be replaced in the resulting binary with a cheap fixup derivation. That derivation will need to be rebuilt on every commit, but it's extremely fast. This only needs to be done for
nickel-lang-cli, since that's the only derivation that actually uses the git revision.