Convert symbols request away from the linearizer #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
approved these changes
Sep 22, 2023
|
@jneem : right, I wonder if we should even put the symbols defined within let-binding at all. Usually, in my limited experience, you're rather looking for record fields - although as you say, even there, it's not clear for the LSP which one are "more top-level" than the others, because Nickel doesn't have a notion of top-level symbols. But returning all the locally defined variable does feel noisy in practice. |
|
I filed #1627 for future improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not completely sure about what should count as a symbol. Right now, let bindings and record fields create "symbols" but function arguments do not.
Returning all locally scoped symbols feels a little noisy to me right now. Maybe the best way to improve it would be to make a symbol hierarchy instead of a flat list. LSP supports this, but we aren't doing it yet.