-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make eval
an explicit subcommand and restructure the CLI somewhat
#1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkleen
changed the title
Feat/nickel eval
Make Sep 26, 2023
eval
an explicit subcommand and restructure the CLI somewhat
jneem
approved these changes
Sep 26, 2023
Co-authored-by: jneem <joeneeman@gmail.com>
yannham
approved these changes
Sep 26, 2023
Co-authored-by: Yann Hamdaoui <yann.hamdaoui@tweag.io>
This was referenced Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
eval
an explicit subcommand for the Nickel CLI and adds the ability to pass multiple files to a single CLI invocation. If multiple files are parsed, they will be evaluated separately and the results merged.Additionally, this PR decouples the customize mode from
nickel export
and instead makes it available anywhere full evaluation is performed.