Add --error-format flag to serialize err diagnostics #1740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1738.
This PR adds an
--error-format
global flag (copied over from Rust, after benchmarking what a few other compilers are donig, this seemed to be the better tradeoff between being intuitive and not conflicting with other meaning of "format as JSON", which we have a lot in Nickel - export format, input format, etc.).The user can choose between JSON, TOML or YAML - I believe JSON is the most common one, but it's virtually free to support more formats with
serde
(at the least the format that we export Nickel configurations to), hence I don't see an obvious reason to not support them.Incidentally, this PR formats more CLI errors using codespan diagnostics (they were just printed as text before), so that the flag really affects all error messages. As a bonus, those error messages are now nicely colored like the others.