Fix --field not applying pending contracts #1778
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1774
The
--field
argument has been added in 1.3 to act only on a specific field of the configuration. However, pending contracts (contracts attached to the field by metadata annotations or propagated through merging) weren't properly applied, leading to illegal values being accepted.This commit fixes the issue by adding the missing contract application step. A snapshot test is added as a regression test. While it's not ideal (we don't encode in the test what is the expected result), it's the best we can do currently for CLI-only tests.
I plan to publish a minor release with this patch, as silently not applying contract is serious enough.