Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix enum contract stripping unwrapping variant argument #1833

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

yannham
Copy link
Member

@yannham yannham commented Mar 1, 2024

Depends on #1835

Fix a bug introduced with enum variant contracts, which would cause a contract such as [| 'Foo Number |] to unwrap the numeric argument of a matching value, that is 'Foo 5 | [| 'Foo Number |] would evaluate to 5 instead of 'Foo 5.

@github-actions github-actions bot temporarily deployed to pull request March 1, 2024 18:27 Inactive
@yannham yannham force-pushed the fix/enum-contract-unwrapping branch from a352698 to 56eaca5 Compare March 5, 2024 09:49
@yannham yannham changed the base branch from master to fix/force-enum-variants March 5, 2024 09:50
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 09:53 Inactive
@yannham yannham force-pushed the fix/enum-contract-unwrapping branch from 56eaca5 to e6d041f Compare March 5, 2024 14:20
@yannham yannham marked this pull request as ready for review March 5, 2024 14:21
@yannham yannham requested review from jneem and vkleen March 5, 2024 14:22
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 14:24 Inactive
Base automatically changed from fix/force-enum-variants to master March 5, 2024 16:21
Copy link

dpulls bot commented Mar 5, 2024

🎉 All dependencies have been resolved !

Fix a bug introduced with enum variant contracts, which would cause a
contract such as `[| 'Foo Number |]` to unwrap the numeric argument of a
matching value, that is `'Foo 5 | [| 'Foo Number |]` would evaluate to
`5` instead of `'Foo 5`.
@yannham yannham force-pushed the fix/enum-contract-unwrapping branch from e6d041f to cbe843c Compare March 5, 2024 16:22
@yannham yannham enabled auto-merge March 5, 2024 16:22
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 16:26 Inactive
@yannham yannham added this pull request to the merge queue Mar 5, 2024
Merged via the queue into master with commit 3d29f0e Mar 5, 2024
5 checks passed
@yannham yannham deleted the fix/enum-contract-unwrapping branch March 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants