Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subsection on enum types in the manual #1836

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Conversation

yannham
Copy link
Member

@yannham yannham commented Mar 5, 2024

As the title says, add subsection on enum types in the typing section of the manual.

@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 16:00 Inactive
@yannham yannham marked this pull request as ready for review March 5, 2024 17:22
@yannham yannham requested review from vkleen and jneem March 5, 2024 17:22
@github-actions github-actions bot temporarily deployed to pull request March 5, 2024 17:26 Inactive
Copy link
Contributor

@vkleen vkleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snippet testing framework demands changes to <repl-input-***> in a few snippets, but I can't add suggestions for it. With that, looks good 👍

doc/manual/typing.md Outdated Show resolved Hide resolved
doc/manual/typing.md Outdated Show resolved Hide resolved
Comment on lines +492 to +493
compatible* with `[| 'Foo Number, 'Bar Number |]`: if something is an enum `'Foo
Number`, then it is surely either `'Foo Number` or `'Bar Number`. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the backticks around 'Foo Number render correctly, even though there's a newline?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, because it happens often when I use neovim to wrap lines around automatically. But let me double check

@github-actions github-actions bot temporarily deployed to pull request March 6, 2024 12:45 Inactive
Co-authored-by: Viktor Kleen <viktor.kleen@tweag.io>
@yannham yannham enabled auto-merge March 7, 2024 11:27
@github-actions github-actions bot temporarily deployed to pull request March 7, 2024 11:30 Inactive
@yannham yannham added this pull request to the merge queue Mar 7, 2024
Merged via the queue into master with commit baf6e3d Mar 7, 2024
5 checks passed
@yannham yannham deleted the doc/enum-types branch March 7, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants